Skip to content

Fix --reuse-db and --create-db not working together. Fixes #411 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ryan-shaw
Copy link
Contributor

@ryan-shaw ryan-shaw commented Dec 12, 2017

Improves upon #476 which fixes #411

Also fixes the test to include db exist check.

@codecov-io
Copy link

codecov-io commented Dec 12, 2017

Codecov Report

Merging #560 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage      92%   92.02%   +0.01%     
==========================================
  Files          33       33              
  Lines        1627     1631       +4     
  Branches      140      140              
==========================================
+ Hits         1497     1501       +4     
  Misses         93       93              
  Partials       37       37
Flag Coverage Δ
#dj110 84.79% <100%> (+0.03%) ⬆️
#dj111 86.08% <100%> (+0.03%) ⬆️
#dj18 85.65% <100%> (+0.03%) ⬆️
#dj19 84.67% <100%> (+0.03%) ⬆️
#dj20 84.36% <100%> (+0.03%) ⬆️
#djmaster 84.36% <100%> (+0.03%) ⬆️
#mysql_innodb 84.3% <100%> (+0.03%) ⬆️
#mysql_myisam 84.24% <100%> (+0.03%) ⬆️
#postgres 87.67% <100%> (+0.03%) ⬆️
#py27 89.39% <100%> (+0.02%) ⬆️
#py34 84.67% <100%> (+0.03%) ⬆️
#py35 84.79% <100%> (+0.03%) ⬆️
#py36 84.85% <100%> (+0.03%) ⬆️
#sqlite 86.14% <100%> (+0.03%) ⬆️
#sqlite_file 84.67% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
tests/test_db_setup.py 100% <100%> (ø) ⬆️
pytest_django/fixtures.py 97.43% <100%> (+0.03%) ⬆️
pytest_django/plugin.py 86.32% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94cccb9...b118990. Read the comment docs.

@blueyed
Copy link
Contributor

blueyed commented Dec 25, 2017

Merged in ac7eb3b, thanks.
Slightly adjusted/formatted the docs.

timb07 pushed a commit to timb07/pytest-django that referenced this pull request May 26, 2018
beyondgeeks pushed a commit to beyondgeeks/django-pytest that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--reuse-db and --create-db not working together
3 participants