Skip to content

Use travis_retry in tox (via install_command), not on tox #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 29, 2015

No description provided.

@blueyed blueyed force-pushed the travis-retry-in-tox branch from 34d7157 to 219aa98 Compare March 29, 2015 20:08
@pelme
Copy link
Member

pelme commented Mar 29, 2015

Very nice!

However, won't this affect local tox runs too? I run tox locally from time to time to run a specific configuration

@blueyed blueyed force-pushed the travis-retry-in-tox branch 2 times, most recently from e837ef2 to ff88ed3 Compare March 29, 2015 20:56
@pelme
Copy link
Member

pelme commented Mar 29, 2015

Very nice with the wrapper!

@blueyed blueyed force-pushed the travis-retry-in-tox branch 4 times, most recently from b88db2e to 335d821 Compare March 29, 2015 22:04
This creates a wrapper script in bin/, exports `travis_retry` (a function)
into it and then injects this as `install_command` into tox.ini.
@blueyed blueyed force-pushed the travis-retry-in-tox branch from f538e02 to 627abe5 Compare March 29, 2015 22:12
@blueyed
Copy link
Contributor Author

blueyed commented Mar 29, 2015

However, won't this affect local tox runs too?

Yes..

The wrapper idea turned to be more complicated than initially hoped, but should work now.

@pelme
Copy link
Member

pelme commented Apr 1, 2015

I have a hard time doing any meaningful review by looking at the diff, but feel free to merge this if it works :)

@blueyed blueyed closed this in 1f279de Apr 6, 2015
@blueyed blueyed deleted the travis-retry-in-tox branch April 6, 2015 03:32
blueyed added a commit to yourlabs/django-autocomplete-light that referenced this pull request Apr 6, 2015
Previously `tox` was run three times on test failures.  Now it should
only get done when pip fails because of network issues.

Based on pytest-dev/pytest-django#224
blueyed added a commit to yourlabs/django-autocomplete-light that referenced this pull request Apr 6, 2015
 - wheels are used and generated through tox' install_command
 - add USE_POSTGRES (default 0)
 - fix check for changed tox.ini in error case
 - use BASEREQ/EXTRAREQ env
 - fix test for tox log
 - PIP_DISABLE_PIP_VERSION_CHECK=true
 - only cache wheelhouse; no .tox anymore
 - travis: use before_cache hook, list with cache.directories
 - use travis_retry through wrapped pip only.  Previously `tox` was run
   three times on test failures.  Now it should only get done when pip
   fails because of network issues.

Based on pytest-dev/pytest-django#224
blueyed added a commit to yourlabs/django-autocomplete-light that referenced this pull request Apr 6, 2015
 - wheels are used and generated through tox' install_command
 - add USE_POSTGRES (default 0)
 - fix check for changed tox.ini in error case
 - use BASEREQ/EXTRAREQ env
 - fix test for tox log
 - PIP_DISABLE_PIP_VERSION_CHECK=true
 - only cache wheelhouse; no .tox anymore
 - travis: use before_cache hook, list with cache.directories
 - use travis_retry through wrapped pip only.  Previously `tox` was run
   three times on test failures.  Now it should only get done when pip
   fails because of network issues.

Based on pytest-dev/pytest-django#224
mfa pushed a commit to aexeagmbh/pytest-django that referenced this pull request May 17, 2017
This creates a wrapper script in bin/, exports `travis_retry` (a function)
into it and then injects this as `install_command` into tox.ini.

Closes pytest-dev#224
beyondgeeks pushed a commit to beyondgeeks/django-pytest that referenced this pull request Sep 6, 2022
This creates a wrapper script in bin/, exports `travis_retry` (a function)
into it and then injects this as `install_command` into tox.ini.

Closes pytest-dev/pytest-django#224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants