-
Notifications
You must be signed in to change notification settings - Fork 346
Use travis_retry
in tox (via install_command), not on tox
#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34d7157
to
219aa98
Compare
Very nice! However, won't this affect local tox runs too? I run tox locally from time to time to run a specific configuration |
e837ef2
to
ff88ed3
Compare
Very nice with the wrapper! |
b88db2e
to
335d821
Compare
This creates a wrapper script in bin/, exports `travis_retry` (a function) into it and then injects this as `install_command` into tox.ini.
f538e02
to
627abe5
Compare
Yes.. The wrapper idea turned to be more complicated than initially hoped, but should work now. |
I have a hard time doing any meaningful review by looking at the diff, but feel free to merge this if it works :) |
blueyed
added a commit
to yourlabs/django-autocomplete-light
that referenced
this pull request
Apr 6, 2015
Previously `tox` was run three times on test failures. Now it should only get done when pip fails because of network issues. Based on pytest-dev/pytest-django#224
blueyed
added a commit
to yourlabs/django-autocomplete-light
that referenced
this pull request
Apr 6, 2015
- wheels are used and generated through tox' install_command - add USE_POSTGRES (default 0) - fix check for changed tox.ini in error case - use BASEREQ/EXTRAREQ env - fix test for tox log - PIP_DISABLE_PIP_VERSION_CHECK=true - only cache wheelhouse; no .tox anymore - travis: use before_cache hook, list with cache.directories - use travis_retry through wrapped pip only. Previously `tox` was run three times on test failures. Now it should only get done when pip fails because of network issues. Based on pytest-dev/pytest-django#224
blueyed
added a commit
to yourlabs/django-autocomplete-light
that referenced
this pull request
Apr 6, 2015
- wheels are used and generated through tox' install_command - add USE_POSTGRES (default 0) - fix check for changed tox.ini in error case - use BASEREQ/EXTRAREQ env - fix test for tox log - PIP_DISABLE_PIP_VERSION_CHECK=true - only cache wheelhouse; no .tox anymore - travis: use before_cache hook, list with cache.directories - use travis_retry through wrapped pip only. Previously `tox` was run three times on test failures. Now it should only get done when pip fails because of network issues. Based on pytest-dev/pytest-django#224
mfa
pushed a commit
to aexeagmbh/pytest-django
that referenced
this pull request
May 17, 2017
This creates a wrapper script in bin/, exports `travis_retry` (a function) into it and then injects this as `install_command` into tox.ini. Closes pytest-dev#224
beyondgeeks
pushed a commit
to beyondgeeks/django-pytest
that referenced
this pull request
Sep 6, 2022
This creates a wrapper script in bin/, exports `travis_retry` (a function) into it and then injects this as `install_command` into tox.ini. Closes pytest-dev/pytest-django#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.