Skip to content

Add Python 3.9 and 3.10 to the testing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 7, 2021

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss!

I fixed a few things, but there's also a bunch of Python version checks that needs updating:

https://github.com/cclauss/nose2pytest/blob/df42b8acc427e18d837fdc3685fb41a350adad3c/nose2pytest/script.py#L93-L112

@cclauss
Copy link
Contributor Author

cclauss commented Nov 8, 2021

Yes. I looked briefly at them and https://github.com/python/cpython/tree/main/Lib/lib2to3 and could not make sense of how they are derived.

Hopefully, time for a new release of nose2pytest given that nose.tools.assert_equals() will raise an AttributeError on Python >= 3.10 and the PyPI version of nose2pytest is far less powerful than the current code in this repo.

@nicoddemus nicoddemus mentioned this pull request Nov 8, 2021
@nicoddemus
Copy link
Member

Yes, see #15

dosas pushed a commit to dosas/nose2pytest that referenced this pull request Jun 27, 2022
@cclauss cclauss closed this Mar 28, 2023
@cclauss cclauss deleted the patch-1 branch March 28, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants