Skip to content

Add a dynamic spinner to show the progress during collection. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2021

Conversation

tobiasraabe
Copy link
Member

Changes

Provide a description and/or bullet points to describe the changes in this PR.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

@tobiasraabe tobiasraabe added this to the v0.0.15 milestone May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #96 (3cc0fec) into main (05b6dd1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3cc0fec differs from pull request most recent head 1c39883. Consider uploading reports for the commit 1c39883 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.03%     
==========================================
  Files          61       60       -1     
  Lines        5144     5132      -12     
==========================================
- Hits         4637     4625      -12     
  Misses        507      507              
Flag Coverage Δ
end_to_end 77.41% <100.00%> (-0.06%) ⬇️
integration 41.50% <30.76%> (-0.12%) ⬇️
unit 66.36% <65.38%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/cli.py 100.00% <ø> (ø)
src/_pytask/collect.py 96.96% <100.00%> (-0.03%) ⬇️
src/_pytask/console.py 96.42% <100.00%> (-0.80%) ⬇️
src/_pytask/debugging.py 30.41% <100.00%> (+0.32%) ⬆️
tests/test_debugging.py 34.13% <100.00%> (+3.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b6dd1...1c39883. Read the comment docs.

@tobiasraabe tobiasraabe merged commit feec8de into main May 26, 2021
@tobiasraabe tobiasraabe deleted the progress-collection branch May 26, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant