Skip to content

Take a common ancestor if closest not available to shorten paths. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2021

Conversation

tobiasraabe
Copy link
Member

Closes #75.

@tobiasraabe tobiasraabe added this to the v0.0.14 milestone Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #76 (21a5ff4) into main (d7903e9) will increase coverage by 0.05%.
The diff coverage is 97.61%.

❗ Current head 21a5ff4 differs from pull request most recent head 456f5b1. Consider uploading reports for the commit 456f5b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   90.17%   90.23%   +0.05%     
==========================================
  Files          55       57       +2     
  Lines        4652     4700      +48     
==========================================
+ Hits         4195     4241      +46     
- Misses        457      459       +2     
Flag Coverage Δ
end_to_end 76.25% <82.14%> (+0.11%) ⬆️
integration 41.76% <69.04%> (+0.17%) ⬆️
unit 68.12% <79.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_nodes.py 93.49% <ø> (-0.63%) ⬇️
src/_pytask/nodes.py 97.51% <81.81%> (-1.31%) ⬇️
src/_pytask/path.py 100.00% <100.00%> (ø)
tests/test_capture.py 99.40% <100.00%> (ø)
tests/test_parametrize.py 89.74% <100.00%> (ø)
tests/test_path.py 100.00% <100.00%> (ø)
tests/test_resolve_dependencies.py 98.27% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7903e9...456f5b1. Read the comment docs.

@tobiasraabe tobiasraabe merged commit 42966a3 into main Mar 21, 2021
@tobiasraabe tobiasraabe deleted the fix-75 branch March 21, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Need graceful error message when passing a path object as depends_on
1 participant