-
Notifications
You must be signed in to change notification settings - Fork 11
Implement a conditional skip marker #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…is True and where the condition is False.
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 90.05% 90.17% +0.11%
==========================================
Files 55 55
Lines 4596 4652 +56
==========================================
+ Hits 4139 4195 +56
Misses 457 457
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Klara, the code is really well written, has tests and documentation! Thanks for great work. 🎉
And thanks for being the first contributor! 🎆
I added some comments to discuss some details. And could you add this PR to the Changes.rst as well as mentioning your handle with:ghuser:`roecla`
?
(sorry for drive-by) apologies for the slow pre-commit.ci run -- github gave us repeated 500s while trying to look up pull request information for this PR (and exhausted our retries). I've requeued it and it looks like it succeeded now. |
That is quite a suprise :). Thanks for stopping by and while you are here, thanks for pre-commit. A minor hiccup is nothing I think too long about given the tremendous benefits I get from the tool. |
Changes
Add a marker called
skip_if
that takes two arguments, a condition and a reason.If the condition is True (or all conditions are True in case more than one
skip_if
marker is used) the task is skipped, else it is run normally.Todo