Skip to content

Fix path in "Node is dir" error message #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

egerlach
Copy link
Contributor

@egerlach egerlach commented Feb 8, 2024

The error message currently displays the path to the source file of the task. This fixes it to be the path of the node being considered.

The error message currently displays the path to the source file of the task.
This fixes it to be the path of the node being considered.
@egerlach egerlach force-pushed the fix-node-path-directory-error branch from d047c51 to 30b22aa Compare February 8, 2024 08:28
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fa5e9a) 97.80% compared to head (30b22aa) 97.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         106      106           
  Lines        8710     8710           
=======================================
  Hits         8519     8519           
  Misses        191      191           
Flag Coverage Δ
end_to_end 82.27% <0.00%> (-0.02%) ⬇️
integration 40.49% <0.00%> (ø)
unit 69.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe
Copy link
Member

Thanks a lot, @egerlach!

@tobiasraabe tobiasraabe merged commit ad3680e into pytask-dev:main Feb 8, 2024
@tobiasraabe tobiasraabe added this to the v0.5.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants