Skip to content

Refactor and better test products. #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Refactor and better test products. #489

merged 1 commit into from
Nov 10, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Nov 10, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.3 milestone Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e525c6f) 96.41% compared to head (3e45e58) 96.42%.

❗ Current head 3e45e58 differs from pull request most recent head 3940aec. Consider uploading reports for the commit 3940aec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   96.41%   96.42%           
=======================================
  Files         104      104           
  Lines        8870     8856   -14     
=======================================
- Hits         8552     8539   -13     
+ Misses        318      317    -1     
Flag Coverage Δ
end_to_end 82.48% <100.00%> (-0.02%) ⬇️
integration 40.48% <50.00%> (+0.07%) ⬆️
unit 67.94% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect_utils.py 99.50% <100.00%> (+0.49%) ⬆️
tests/test_execute.py 99.22% <100.00%> (-0.03%) ⬇️
tests/test_task.py 99.56% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 7885402 into main Nov 10, 2023
@tobiasraabe tobiasraabe deleted the fix-products branch November 10, 2023 17:47
tobiasraabe added a commit that referenced this pull request Nov 11, 2023
tobiasraabe added a commit that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant