Skip to content

Give skips higher precendence than ancestor failed as outcome. #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Nov 7, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Nov 7, 2023
@tobiasraabe tobiasraabe enabled auto-merge (squash) November 7, 2023 16:59
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1c76085) 94.39% compared to head (459dd62) 94.47%.
Report is 1 commits behind head on main.

❗ Current head 459dd62 differs from pull request most recent head 294f879. Consider uploading reports for the commit 294f879 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   94.39%   94.47%   +0.07%     
==========================================
  Files         104      104              
  Lines        9053     9065      +12     
==========================================
+ Hits         8546     8564      +18     
+ Misses        507      501       -6     
Flag Coverage Δ
end_to_end 81.22% <88.53%> (-0.07%) ⬇️
integration 39.76% <50.31%> (+0.05%) ⬆️
unit 67.08% <89.80%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect.py 92.64% <100.00%> (+0.82%) ⬆️
src/_pytask/console.py 97.36% <100.00%> (+1.40%) ⬆️
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/debugging.py 71.17% <100.00%> (-0.13%) ⬇️
src/_pytask/execute.py 97.28% <100.00%> (+0.23%) ⬆️
src/_pytask/hookspecs.py 100.00% <ø> (ø)
src/_pytask/live.py 98.73% <ø> (ø)
src/_pytask/logging.py 96.07% <100.00%> (+0.33%) ⬆️
src/_pytask/outcomes.py 96.05% <ø> (ø)
src/_pytask/persist.py 100.00% <ø> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 2eb480e into main Nov 7, 2023
@tobiasraabe tobiasraabe deleted the skip-over-ancestor-failed branch November 7, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant