Skip to content

Add is_product to PNode.load(). #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add is_product to PNode.load(). #472

merged 2 commits into from
Oct 31, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 31, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 31, 2023
@tobiasraabe tobiasraabe changed the title Add is_product to PNode.load. Add is_product to PNode.load(). Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d543bc) 82.27% compared to head (cdefe07) 95.00%.

❗ Current head cdefe07 differs from pull request most recent head 384d0d5. Consider uploading reports for the commit 384d0d5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #472       +/-   ##
===========================================
+ Coverage   82.27%   95.00%   +12.72%     
===========================================
  Files          97       97               
  Lines        8588     8610       +22     
===========================================
+ Hits         7066     8180     +1114     
+ Misses       1522      430     -1092     
Flag Coverage Δ
end_to_end 82.25% <80.64%> (-0.03%) ⬇️
integration 39.50% <45.16%> (?)
unit 65.93% <80.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/execute.py 97.05% <100.00%> (ø)
src/_pytask/node_protocols.py 100.00% <100.00%> (ø)
src/_pytask/nodes.py 86.40% <100.00%> (+3.23%) ⬆️
tests/test_execute.py 99.11% <100.00%> (+0.03%) ⬆️
tests/test_node_protocols.py 100.00% <ø> (ø)
tests/test_nodes.py 100.00% <100.00%> (+33.33%) ⬆️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 58d940e into main Oct 31, 2023
@tobiasraabe tobiasraabe deleted the add-is-product branch October 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant