Skip to content

Hash files instead of relying on modification timestamps. #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Nov 2, 2023
Merged

Conversation

tobiasraabe
Copy link
Member

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (4da749b) 94.96% compared to head (fec1272) 94.34%.

❗ Current head fec1272 differs from pull request most recent head 4061e6e. Consider uploading reports for the commit 4061e6e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   94.96%   94.34%   -0.62%     
==========================================
  Files          99      104       +5     
  Lines        8794     9033     +239     
==========================================
+ Hits         8351     8522     +171     
- Misses        443      511      +68     
Flag Coverage Δ
end_to_end 81.35% <53.92%> (-0.93%) ⬇️
integration 39.39% <32.50%> (-0.17%) ⬇️
unit 66.24% <72.85%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/build.py 99.03% <100.00%> (+0.17%) ⬆️
src/_pytask/dag.py 100.00% <ø> (ø)
src/_pytask/database_utils.py 94.28% <100.00%> (-1.46%) ⬇️
src/_pytask/nodes.py 86.61% <100.00%> (+1.69%) ⬆️
src/_pytask/path.py 93.58% <100.00%> (+0.73%) ⬆️
src/pytask/path.py 100.00% <100.00%> (ø)
tests/test_cache.py 100.00% <100.00%> (ø)
tests/test_database.py 100.00% <100.00%> (ø)
tests/test_execute.py 99.15% <100.00%> (+0.02%) ⬆️
tests/test_hashlib.py 100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from draft-datastore to main November 2, 2023 09:38
@tobiasraabe tobiasraabe merged commit 32e02f8 into main Nov 2, 2023
@tobiasraabe tobiasraabe deleted the hashing branch November 2, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant