Skip to content

Modernize TopologicalSorter. #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Modernize TopologicalSorter. #458

merged 7 commits into from
Nov 9, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 21, 2023

Changes

  • Remove unused parts.
  • Remove duplicated dag.
  • Allow to dynamically add tasks.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a4592) 96.41% compared to head (5a15958) 96.41%.

❗ Current head 5a15958 differs from pull request most recent head cb5867d. Consider uploading reports for the commit cb5867d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   96.41%   96.41%   -0.01%     
==========================================
  Files         104      104              
  Lines        8864     8862       -2     
==========================================
- Hits         8546     8544       -2     
  Misses        318      318              
Flag Coverage Δ
end_to_end 82.55% <46.00%> (-0.04%) ⬇️
integration 40.43% <14.00%> (-0.05%) ⬇️
unit 67.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/dag_utils.py 100.00% <100.00%> (ø)
src/_pytask/execute.py 99.43% <100.00%> (ø)
tests/test_dag_utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe modified the milestones: v0.4.2, v0.4.3 Nov 8, 2023
@tobiasraabe tobiasraabe merged commit 2bd471f into main Nov 9, 2023
@tobiasraabe tobiasraabe deleted the dag branch November 9, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant