Skip to content

Refactor code for format_node_name. #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Refactor code for format_node_name. #457

merged 2 commits into from
Oct 20, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 20, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 20, 2023
@tobiasraabe tobiasraabe changed the title Refactor code for format_node_name. Refactor code for format_node_name. Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b790e5d) 95.02% compared to head (6763cff) 95.01%.

❗ Current head 6763cff differs from pull request most recent head e20d4f6. Consider uploading reports for the commit e20d4f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   95.02%   95.01%   -0.01%     
==========================================
  Files          97       97              
  Lines        8540     8549       +9     
==========================================
+ Hits         8115     8123       +8     
- Misses        425      426       +1     
Flag Coverage Δ
end_to_end 82.43% <78.78%> (+<0.01%) ⬆️
integration 39.59% <59.09%> (+0.12%) ⬆️
unit 64.97% <51.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect_command.py 89.90% <100.00%> (-0.61%) ⬇️
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/execute.py 97.08% <100.00%> (ø)
tests/test_collect_command.py 100.00% <100.00%> (ø)
tests/test_console.py 98.80% <100.00%> (+0.17%) ⬆️
tests/test_dag.py 98.13% <100.00%> (ø)
tests/test_nodes.py 100.00% <ø> (ø)
src/_pytask/collect.py 91.62% <60.00%> (-0.83%) ⬇️
src/_pytask/console.py 95.20% <90.90%> (+0.70%) ⬆️
src/_pytask/shared.py 90.24% <40.00%> (+6.91%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 7f38d32 into main Oct 20, 2023
@tobiasraabe tobiasraabe deleted the format-node-name branch October 20, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant