Skip to content

Add more explanation when PNode.load() fails during execution. #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 18, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 18, 2023
@tobiasraabe tobiasraabe changed the title Add more explanation when PNode.load() fails during execution. Add more explanation when PNode.load() fails during execution. Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3dca093) 95.00% compared to head (7cb8809) 82.42%.

❗ Current head 7cb8809 differs from pull request most recent head df3c541. Consider uploading reports for the commit df3c541 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #455       +/-   ##
===========================================
- Coverage   95.00%   82.42%   -12.59%     
===========================================
  Files          97       97               
  Lines        8510     8540       +30     
===========================================
- Hits         8085     7039     -1046     
- Misses        425     1501     +1076     
Flag Coverage Δ
end_to_end 82.42% <100.00%> (+0.34%) ⬆️
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/exceptions.py 100.00% <100.00%> (ø)
src/_pytask/execute.py 97.08% <100.00%> (+0.16%) ⬆️
tests/test_collect_command.py 94.40% <100.00%> (-5.60%) ⬇️
tests/test_execute.py 99.07% <100.00%> (+0.02%) ⬆️
tests/test_node_protocols.py 100.00% <100.00%> (ø)
tests/test_path.py 33.55% <100.00%> (-62.39%) ⬇️
tests/test_typing.py 42.85% <100.00%> (-48.81%) ⬇️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe enabled auto-merge (squash) October 18, 2023 14:32
@tobiasraabe tobiasraabe merged commit 67e328b into main Oct 18, 2023
@tobiasraabe tobiasraabe deleted the more-exp branch October 18, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant