Skip to content

Don't display a table when no entry is present. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jan 9, 2022

  • Don't display a table if no row was added.
  • Remove unnecessary if-clause.

@tobiasraabe tobiasraabe added this to the v0.1.5 milestone Jan 9, 2022
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #189 (94c6a25) into main (3428f00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   92.80%   92.81%           
=======================================
  Files          71       71           
  Lines        6714     6718    +4     
=======================================
+ Hits         6231     6235    +4     
  Misses        483      483           
Flag Coverage Δ
end_to_end 79.04% <83.33%> (-0.02%) ⬇️
integration 42.08% <0.00%> (-0.03%) ⬇️
unit 68.91% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/live.py 99.37% <100.00%> (+<0.01%) ⬆️
tests/test_live.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3428f00...94c6a25. Read the comment docs.

@tobiasraabe tobiasraabe merged commit 99ba717 into main Jan 9, 2022
@tobiasraabe tobiasraabe deleted the dont-display-table-wo-entries branch January 9, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant