Skip to content

Add new hook pytask_unconfigure, return borrowed pdb.set_trace at the end of session, reenable tests for PytaskPDB. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

tobiasraabe
Copy link
Member

Changes

Provide a description and/or bullet points to describe the changes in this PR.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

… end of session, reenable tests for PytaskPDB.
@tobiasraabe tobiasraabe added this to the v0.0.15 milestone Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #107 (4372849) into main (650334d) will increase coverage by 3.18%.
The diff coverage is 95.23%.

❗ Current head 4372849 differs from pull request most recent head 9cd9f96. Consider uploading reports for the commit 9cd9f96 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   90.12%   93.30%   +3.18%     
==========================================
  Files          62       62              
  Lines        5243     5260      +17     
==========================================
+ Hits         4725     4908     +183     
+ Misses        518      352     -166     
Flag Coverage Δ
end_to_end 79.96% <95.23%> (+3.23%) ⬆️
integration 41.67% <39.68%> (+0.05%) ⬆️
unit 67.22% <60.31%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/debugging.py 31.94% <60.00%> (+1.52%) ⬆️
src/_pytask/capture.py 85.04% <93.33%> (ø)
src/_pytask/build.py 94.00% <100.00%> (+0.12%) ⬆️
src/_pytask/hookspecs.py 100.00% <100.00%> (ø)
tests/test_debugging.py 99.24% <100.00%> (+65.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650334d...9cd9f96. Read the comment docs.

@tobiasraabe tobiasraabe merged commit 6067e73 into main Jun 21, 2021
@tobiasraabe tobiasraabe deleted the fix-pytest-pytask-pdb branch June 21, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant