-
Notifications
You must be signed in to change notification settings - Fork 2
Implementation of build steps and support for old API #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @axtimhaus, this looks awesome! Can I offer any help or are you just looking for some time to finish the implementation? |
If you would check up the tests I would be thankful ;) |
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 98.85% 98.60% -0.26%
==========================================
Files 14 17 +3
Lines 524 572 +48
==========================================
+ Hits 518 564 +46
- Misses 6 8 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @axtimhaus, I got the tests running and made some changes to the code. Here is some feedback:
|
Hi @tobiasraabe, yes, you are right, I lack a bit of discipline in that stuff... So could I get over to implement the other steps? |
No problem. If you like you can move over implementing the other build steps. I'll wrap up this PR probably on Monday and document the new interface. |
Hi @axtimhaus, I finished the readme. Just one thing which might sound silly. If people want to abbreviate the import for the build steps, they might do |
Changes
Todo