Make polyscript.js_modules crawable #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
force-pushed
the
crawable-js-modules
branch
from
5c15181 to
f8b98e6
Compare
WebReflection
force-pushed
the
crawable-js-modules
branch
from
f8b98e6 to
062d6be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR addresses in polyscript the issue described in here: pyscript/pyscript#1903
It does so by adding all known modules as proxy and by testing these work in both the main thread and the worker thread.
Details
as soon as I register a JS module the pyodide interpreter tries to access all fields making the lazy loading (on demand) completely useless.
The current MR leaves Pyodide AS-IS because it's smart enough to crawl already JS references / namespaces without overly-bothering the module paths map/stack.
This MR has been successfully tested on both Pyodide and MicroPython.