Skip to content

Update DynamicFieldsEnum to include all deprecated fields #17409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

di
Copy link
Member

@di di commented Jan 14, 2025

Alternative to #17390 given pypa/setuptools#4797 (comment).

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the revert commit and just updating the enum. This will retain validation that Dynamic contains values that we have in the enum, as well as the typo fixes from the previous PR.

@di di force-pushed the handle-deprecated-dynamic-metadata branch from 8e613f5 to 6601704 Compare January 14, 2025 17:08
@di di force-pushed the handle-deprecated-dynamic-metadata branch from 6601704 to f5e205f Compare January 14, 2025 17:10
@di di requested a review from ewdurbin January 14, 2025 17:16
@di di enabled auto-merge (squash) January 14, 2025 17:40
@di di merged commit a8a9391 into pypi:main Jan 14, 2025
20 checks passed
@di di deleted the handle-deprecated-dynamic-metadata branch January 14, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants