Skip to content

PyPI is now requiring wheels to be too much compressed #13962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moriyoshi opened this issue Jun 17, 2023 · 2 comments
Closed

PyPI is now requiring wheels to be too much compressed #13962

moriyoshi opened this issue Jun 17, 2023 · 2 comments
Labels
bug 🐛 requires triaging maintainers need to do initial inspection of issue

Comments

@moriyoshi
Copy link

moriyoshi commented Jun 17, 2023 •
edited
Loading

Describe the bug

The change (#13877) done in last week made my valid wheels that contain some native shared objects totally unuploadable. IMO requiring compression ratio < 0.1 is pretty rigorous.

Expected behavior

The threshold is too heuristic. Mitigation for zipbombs should be done in another way.

To Reproduce

Build any wheel of the following project and upload it to pypi:

https://github.com/opencollector/jntajis-python

My Platform

I am using cibuildwheel to build wheels.

Additional context

N/A
@moriyoshi moriyoshi added bug 🐛 requires triaging maintainers need to do initial inspection of issue labels Jun 17, 2023
@moriyoshi moriyoshi mentioned this issue Jun 17, 2023
Closed
@miohtama
Copy link
Contributor

I encountered this issue with web3-ethereum-defi and can no longer not upload new versions of the package produced with Poetry.

Poetry discussion here.

miohtama added a commit to miohtama/warehouse that referenced this issue Jun 20, 2023
@miohtama
Fix ZIP bomb threshold too low
2216d3e 
See pypi#13962
@miohtama miohtama mentioned this issue Jun 20, 2023
Merged
miohtama added a commit to tradingstrategy-ai/web3-ethereum-defi that referenced this issue Jun 20, 2023
@miohtama
Attempting to fix pypi/warehouse#13962
fccd517
ewdurbin added a commit that referenced this issue Jun 21, 2023
@miohtama @ewdurbin
Fix ZIP bomb threshold too low (#13967)
5a0289e 
* Fix ZIP bomb threshold too low

See #13962

* Update legacy.py

Set threshold to 100x

* Update warehouse/forklift/legacy.py

---------

Co-authored-by: Ee Durbin <[email protected]>
@di
Copy link
Member

di commented Jun 23, 2023

Should be fixed by #13967.

@di di closed this as completed Jun 23, 2023
msk-rj921 pushed a commit to InvoBloxTeamHub/ethereum-defi-protocol that referenced this issue Apr 7, 2025
@miohtama
Attempting to fix pypi/warehouse#13962
ccd9bc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 requires triaging maintainers need to do initial inspection of issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moriyoshi @miohtama @di