Skip to content

Update distutils #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 5, 2021
Merged

Update distutils #2714

merged 22 commits into from
Jul 5, 2021

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jul 4, 2021

  • Add clang mingw support
  • Fixed get_export_symbols for unicode filenames
  • Change get_gcc_versions back to get_versions
  • distutils: pass -rpath to linker on macOS >=10.5
  • Prefer using Distribution.has_ext_modules method
  • 👹 Feed the hobgoblins (delint).
  • Remove automerge.
  • Add test capturing failure. Ref Avoid symlink infinite loops distutils#44.
  • Ensure that the result contains only the one file, not all the different symlink variants to the same file.
  • Wrap walk result to prevent infinite recursion. Fixes bpo-44497.
  • Extract UniqueDirs for checking uniqueness.
  • Rely on stat (inode and device) to deduplicate.
  • Move _unique_dirs into classmethod on _UniqueDirs.

Summary of changes

Closes

Pull Request Checklist

longnguyen2004 and others added 20 commits February 4, 2021 19:29
The implementation of `get_export_symbols` from distutils doesn't quite conform to PEP-489
(because `"_<name>".encode('punycode') != "<name>".encode('punycode')`).
This affects the linking of unicode modules on Windows
Fix -R option of build_ext for macOS (darwin)

Resolves this old bug against distutils that expired due to PIP 632:
https://bugs.python.org/issue36353

Applies patch originally submitted to CPython:
python/cpython#12418

Contributor: Toon Verstraelen <[email protected]>
Signed-off-by: Alexei Colin <[email protected]>
Fixed get_export_symbols for unicode filenames
distutils: pass -rpath on macOS when requested
Prefer using `Distribution.has_ext_modules` method
Avoid symlink infinite loops (separate concerns + repro)
@jaraco jaraco force-pushed the feature/distutils-sync branch from f3e30fc to 1b78cdf Compare July 4, 2021 19:29
@jaraco jaraco closed this Jul 4, 2021
@jaraco jaraco reopened this Jul 4, 2021
@jaraco jaraco closed this Jul 5, 2021
@jaraco jaraco reopened this Jul 5, 2021
@jaraco jaraco mentioned this pull request Jul 5, 2021
2 tasks
@jaraco jaraco force-pushed the feature/distutils-sync branch from 1b78cdf to d4f066a Compare July 5, 2021 02:36
@jaraco jaraco merged commit 20337b4 into main Jul 5, 2021
@jaraco jaraco deleted the feature/distutils-sync branch July 5, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants