Skip to content

Dirty working directory not being correctly detected when tags are missing #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinghajj opened this issue May 13, 2016 · 4 comments
Closed
Assignees
Labels

Comments

@kinghajj
Copy link

I'm working with a "big repo" with many libraries/services. One service, "tasks," references the "model" library in its requirements.txt

../lib/model

If I run

$ pex -r requirements.txt -o test.pex

Then the generated wheel in ~/.pex/build is called model-0.1.dev239+n6e5cad8-py2-none-any.whl, which doesn't have the timestamp that the documentation suggests, despite the fact that the repository is dirty:

Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

    modified:   lib/model/setup.py
    modified:   workers/tasks/requirements.txt
@RonnyPfannschmidt
Copy link
Contributor

at first glace that looks like a problem with git describe interpretation

whats the output of git describe? also please run the SETUPTOOLS_SCM_DEBUG=1' python setup.py --version

@kinghajj
Copy link
Author

fatal: No names found, cannot describe anything.

Which apparently is caused by not having any tags--which is expected, since this is a fairly new repo. Maybe that requirement should be mentioned in the documentation? Thanks for the help.

@RonnyPfannschmidt
Copy link
Contributor

no, thats actually a bug - the handler for nothign to describe doesnt check if there is changes in the workdir

@RonnyPfannschmidt RonnyPfannschmidt changed the title Dirty working directory not being correctly detected Dirty working directory not being correctly detected when tags are missing May 13, 2016
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Oct 10, 2016
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Oct 10, 2016
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Oct 10, 2016
@RonnyPfannschmidt
Copy link
Contributor

closed by d041864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants