Limit body width

[pradyunsg]

A PR to eventually close #9.

[pradyunsg]

Currently, the width is 1000px and the content now has a right border for visual clarity.

small screen

large screen

The right border should probably be removed on screens with width < 1000px; I'll do it if others think having the border is useful in the first place. Ideally, I'd like to change the styling a fair bit but not just yet. :)

[pradyunsg]

@jonparrott I have a bunch of other improvements that I want to make:

• topbar
  • make the go button and search bar height consistent
• sidebar
  • overlap on mobile instead of expand
  • make top-to-bottom, instead of having (IMO) a weird margin all around
• overall
  • make the pages full height even if the content is small
  • remove the body-padding and make it the lines touch end-to-end (needs discussion)
    • it'd be boxy but I think that'll look nicer
• footer
  • make content show up on both sides on large displays

These are inherited from python-docs-theme; should I make issues for them upstream on the python-docs-theme repo? If so, I'll make an issue for the limit-width as well then?

(edited)

[pradyunsg]

Aside -- another thing that can be done is move the entire body into the middle, like this:

[theacodes]

These are inherited from python-docs-theme; should I make issues for them upstream on the python-docs-theme repo? If so, I'll make an issue for the limit-width as well then?

Yes, that's strongly preferred.

[pradyunsg]

Yes, that's strongly preferred.

idk why but I'm nervous to do that. :|

[theacodes]

If it makes you feel better I'm the one that started the upstream repo?

…

On Wed, Nov 8, 2017, 9:46 AM Pradyun Gedam ***@***.***> wrote: Yes, that's strongly preferred. idk why but I'm nervous to do that. :| — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc4m45zFROLYxTk0ClUvcC5hB7aclks5s0ejjgaJpZM4QUW76> .

[pradyunsg]

If it makes you feel better I'm the one that started the upstream repo?

I guess it does.

I just got overwhelmed looking at the watchers list. 🤷‍♂️

[pfmoore]

Apparently it's just the Python committers being added automatically - I'm on there and I'm pretty sure I didn't explicitly watch it. Enjoy the fame :-)

[pradyunsg]

it's just the Python committers being added automatically

Makes sense.

Enjoy the fame :-)

Thanks, I guess.

---

On a completely different note, is anyone else even lukewarm to the idea of making an issue regarding unifying the styling of docs.python.org with python.org over on that repo? ._.

[pradyunsg]

Any inputs on this PR? (or that question above :P)

[theacodes]

Any inputs on this PR? (or that question above :P)

Would still prefer this to happen upstream if at all possible, but, if you feel like this is important enough to do here and now I'm happy to review and merge.

On a completely different note, is anyone else even lukewarm to the idea of making an issue regarding unifying the styling of docs.python.org with python.org over on that repo? ._.

Go for it, discussion is always good.

[pradyunsg]

Go for it, discussion is always good.

What's the right place for it?

[pradyunsg]

Would still prefer this to happen upstream if at all possible, but, if you feel like this is important enough to do here and now I'm happy to review and merge.

Well then, let's give it a shot upstream. I'm guessing it's gonna be a fairly similar PR there.

[pradyunsg]

@jonparrott @pfmoore There's no activity on python/python-docs-theme#4. ._.

Should I ping there or is it a better idea to just get this one done and then proceed upstream?

[pradyunsg]

Ping!

@jonparrott Can we go ahead and make this change here?

[Mariatta]

IMO this change should be made first here in pypa.
If we learned that everyone likes this new change, and they wished docs.python.org be updated, at that time it can be proposed upstream :)

[pradyunsg]

Thanks for the comment @Mariatta! Sounds good to me. :)

[pradyunsg]

@jonparrott I don't think this PR was ready for a merge. None the less, I'll make another PR with a more polished look. :)