Use keyword-only arguments #9412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
approved these changes
Jan 26, 2021
uranusjr
reviewed
Jan 30, 2021
https://www.python.org/dev/peps/pep-3102/ Replaces the pattern: self.name = kwargs.pop('name') Keyword-only arguments offer some advantages: - In the event of a typo or misuse, a more informative error is presented to the programmer. - More self documenting and makes interfaces more explicit. - They more easily allow explicit typing. Adding types to ConfigOptionParser required changing some call sites to pass arguments without using a dict due to mypy bug: python/mypy#9676
uranusjr
approved these changes
Jan 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.python.org/dev/peps/pep-3102/
Replaces the pattern:
self.name = kwargs.pop('name')Keyword-only arguments offer some advantages:
Adding types to
ConfigOptionParserrequired changing some call sites to pass arguments without using a dict due to mypy bug:python/mypy#9676