Skip to content

Upgrade flake8 to 3.8.1 #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020
Merged

Upgrade flake8 to 3.8.1 #8261

merged 1 commit into from
May 19, 2020

Conversation

deveshks
Copy link
Contributor

Upgrading flake8 from 3.7.9 -> 3.8.1, applying changes suggested in #8235 (comment)

@deveshks deveshks mentioned this pull request May 18, 2020
@asottile
Copy link
Contributor

asottile commented May 18, 2020

can you add Co-Authored-By: <Anthony Sottile [email protected]> to the commits since it's essentially my patch

@deveshks
Copy link
Contributor Author

can you add Co-Authored-By: <Anthony Sottile [email protected]> to the commits since it's essentially my patch

Oops sorry about that. I have added you as the co-author.

@asottile
Copy link
Contributor

ah shoot I have the syntax wrong my b

it's

Co-Authored-By: Anthony Sottile <[email protected]>

Co-Authored-By: Anthony Sottile <[email protected]>
@deveshks
Copy link
Contributor Author

ah shoot I have the syntax wrong my b

it's

Co-Authored-By: Anthony Sottile <[email protected]>

Fixed, can you check to verify if it's correct now?

@asottile
Copy link
Contributor

ah shoot I have the syntax wrong my b
it's

Co-Authored-By: Anthony Sottile <[email protected]>

Fixed, can you check to verify if it's correct now?

yep! looks good (see how github gives both of us a picture in the commit)

@deveshks
Copy link
Contributor Author

yep! looks good (see how github gives both of us a picture in the commit)

Yes, I was wondering why your name wasn't showing up as co-committer. Thanks for that.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label May 19, 2020
@pradyunsg pradyunsg merged commit d4cd5b9 into pypa:master May 19, 2020
@pradyunsg
Copy link
Member

Awesome! Many thanks @deveshks and @asottile! ^>^

@deveshks deveshks deleted the upgrade-flake8 branch May 21, 2020 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants