Skip to content

Keep symlinks as symlinks when installing #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Keep symlinks as symlinks when installing #1012

wants to merge 1 commit into from

Conversation

myint
Copy link
Contributor

@myint myint commented Jun 26, 2013

This fixes #1006.

Without this, "pip install" crashes when encountering symlinks that
point to external paths. The culprit is "shutil.copytree()", which
throws an error in such cases if the "symlinks" parameter is not set to
"True".

This fixes #1006.
@myint
Copy link
Contributor Author

myint commented Jul 12, 2013

Quite some time ago, I tried without success to get the pip tests running cleanly on my machine. I've given up on wasting time on it.

@jstasiak
Copy link
Contributor

+1, have been encountering this issue with pip and Python 3 for a while now.

@pnasrat
Copy link
Contributor

pnasrat commented Aug 12, 2013

@myint perhaps you can explain your test failures, but in theory even with failing tests you should be able to construct a working testcase.

@myint
Copy link
Contributor Author

myint commented Aug 24, 2013

I took @pnasrat's suggestion and just ignored all tests except for test_install_from_local_directory() which luckily works on my machine. See #1166.

@myint myint closed this Aug 24, 2013
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants