-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Document iOS, Android and macOS platform tag schemes. #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI @mhsmith |
Co-authored-by: Malcolm Smith <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The macOS tag information LGTM, thanks.
Thanks for the pointers on what the actual ground truth is here. FYI: I've opened pypi/warehouse#17566 to track the issue on warehouse, and python/cpython#129712 to track the missing documentation (and inconsistency with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a ton @freakboy3742!
Co-authored-by: Malcolm Smith <[email protected]>
I don't have access to resolve my conversations above, but everything looks good to me now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks @freakboy3742. If CI checks are happy, I will try to merge.
Adds documentation for the iOS PEP 730, Android PEP 738 platform tags.
Also adds documentation for macOS tags, given they have their own quirks (especially regarding the
universal
fat architecture specification).Fixes #1801
Fixes #1802
📚 Documentation preview 📚: https://python-packaging-user-guide--1804.org.readthedocs.build/en/1804/