-
Notifications
You must be signed in to change notification settings - Fork 155
test: add manylinux_2_28 tests #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
webhooks & GHA currently out of order: https://www.githubstatus.com/incidents/vvthhf8gxt80 |
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 92.42% 92.36% -0.06%
==========================================
Files 23 23
Lines 1267 1258 -9
Branches 311 307 -4
==========================================
- Hits 1171 1162 -9
Misses 55 55
Partials 41 41
Continue to review full report at Codecov.
|
tests/integration/test_manylinux.py
Outdated
@@ -708,9 +708,7 @@ def test_glibcxx_3_4_25(self, any_manylinux_container, docker_python, io_folder) | |||
assert orig_wheel.startswith("testentropy-0.0.1") | |||
|
|||
# Repair the wheel using the appropriate manylinux container | |||
repair_command = ( | |||
f"auditwheel repair --plat {policy} --strip -w /io /io/{orig_wheel}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably not try to strip system libraries that get grafted.
the tests fails on musllinux because libstdc++ and/or libgcc_s get stripped.
88f13df
to
cf2b21e
Compare
Now that pypa/manylinux#1277 is merged, can this PR be rebased? |
draft just to see if we're seeing complaints with
GLIBCXX_3.4.25
symbol version.