Skip to content

test: add manylinux_2_28 tests #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2022
Merged

test: add manylinux_2_28 tests #369

merged 2 commits into from
Jun 2, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 5, 2022

draft just to see if we're seeing complaints with GLIBCXX_3.4.25 symbol version.

@mayeut mayeut closed this Feb 5, 2022
@mayeut mayeut reopened this Feb 5, 2022
@mayeut
Copy link
Member Author

mayeut commented Feb 5, 2022

webhooks & GHA currently out of order: https://www.githubstatus.com/incidents/vvthhf8gxt80
let's wait to see how it goes...

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #369 (4bce4ab) into main (fe45465) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 4bce4ab differs from pull request most recent head 3d9bb59. Consider uploading reports for the commit 3d9bb59 to get more accurate results

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   92.42%   92.36%   -0.06%     
==========================================
  Files          23       23              
  Lines        1267     1258       -9     
  Branches      311      307       -4     
==========================================
- Hits         1171     1162       -9     
  Misses         55       55              
  Partials       41       41              
Impacted Files Coverage Δ
src/auditwheel/repair.py 85.59% <0.00%> (-0.70%) ⬇️
src/auditwheel/main_repair.py 90.47% <0.00%> (-0.15%) ⬇️
src/auditwheel/patcher.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe45465...3d9bb59. Read the comment docs.

@@ -708,9 +708,7 @@ def test_glibcxx_3_4_25(self, any_manylinux_container, docker_python, io_folder)
assert orig_wheel.startswith("testentropy-0.0.1")

# Repair the wheel using the appropriate manylinux container
repair_command = (
f"auditwheel repair --plat {policy} --strip -w /io /io/{orig_wheel}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably not try to strip system libraries that get grafted.
the tests fails on musllinux because libstdc++ and/or libgcc_s get stripped.

@EwoutH
Copy link

EwoutH commented Jun 1, 2022

Now that pypa/manylinux#1277 is merged, can this PR be rebased?

@mayeut mayeut marked this pull request as ready for review June 2, 2022 20:56
@mayeut mayeut merged commit 55bc5ee into pypa:main Jun 2, 2022
@mayeut mayeut deleted the manylinux_2_28 branch October 9, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants