100% test coverage of framers.

Author: janiversen

test/framers/conftest.py

@@ -10,7 +10,7 @@
 @pytest.fixture(name="entry")
 def prepare_entry():
     """Return framer_type."""
-    return FramerType.ASCII
+    return FramerType.RTU
 
 @pytest.fixture(name="is_server")
 def prepare_is_server():

test/framers/test_framer.py

@@ -10,10 +10,19 @@
 from pymodbus.framer.socket import FramerSocket
 from pymodbus.framer.tls import FramerTLS
 
+from .generator import set_calls
+
 
 class TestFramer:
     """Test module."""
 
+    def test_setup(self, entry, is_server, dev_ids):
+        """Test conftest."""
+        assert entry == FramerType.RTU
+        assert not is_server
+        assert dev_ids == [0, 17]
+        set_calls()
+
     @pytest.mark.parametrize(("entry"), list(FramerType))
     async def test_framer_init(self, test_framer):
         """Test framer type."""
@@ -291,6 +300,7 @@ async def test_decode_type(self, entry, test_framer, data, dev_id, tr_id, expect
                  (12, b"\x03\x00\x7c\x00\x02"),
                  (12, b"\x03\x00\x7c\x00\x02"),
             ]),
+            (FramerType.SOCKET, b'\x0c\x05\x00\x00\x00\x02\xff\x83\x02', [(9, b'\x83\x02')],),  # Exception
             (FramerType.RTU, b'\x00\x83\x02\x91\x21', [ # bad crc
                  (2, b''),
             ]),

test/framers/test_multidrop.py

@@ -7,7 +7,7 @@
 from pymodbus.server.async_io import ServerDecoder
 
 
-class NotImplementedTestMultidrop:
+class TestMultidrop:
     """Test that server works on a multidrop line."""
 
     good_frame = b"\x02\x03\x00\x01\x00}\xd4\x18"
@@ -28,7 +28,8 @@ def test_ok_frame(self, framer, callback):
         framer.processIncomingPacket(serial_event, callback)
         callback.assert_called_once()
 
-    def test_ok_2frame(self, framer, callback):
+    @pytest.mark.skip
+    def test_ok_2frame(self, framer, callback):  # pragma: no cover
         """Test ok frame."""
         serial_event = self.good_frame + self.good_frame
         framer.processIncomingPacket(serial_event, callback)
@@ -65,7 +66,8 @@ def test_big_split_response_frame_from_other_id(self, framer, callback):
             framer.processIncomingPacket(serial_event, callback)
         callback.assert_not_called()
 
-    def test_split_frame(self, framer, callback):
+    @pytest.mark.skip
+    def test_split_frame(self, framer, callback):  # pragma: no cover
         """Test split frame."""
         serial_events = [self.good_frame[:5], self.good_frame[5:]]
         for serial_event in serial_events:
@@ -86,31 +88,35 @@ def test_complete_frame_trailing_data_with_id(self, framer, callback):
         framer.processIncomingPacket(serial_event, callback)
         callback.assert_called_once()
 
-    def test_split_frame_trailing_data_with_id(self, framer, callback):
+    @pytest.mark.skip
+    def test_split_frame_trailing_data_with_id(self, framer, callback):  # pragma: no cover
         """Test split frame."""
         garbage = b"\x05\x04\x03\x02\x01\x00"
         serial_events = [garbage + self.good_frame[:5], self.good_frame[5:]]
         for serial_event in serial_events:
             framer.processIncomingPacket(serial_event, callback)
         callback.assert_called_once()
 
-    def test_coincidental_1(self, framer, callback):
+    @pytest.mark.skip
+    def test_coincidental_1(self, framer, callback):  # pragma: no cover
         """Test conincidental."""
         garbage = b"\x02\x90\x07"
         serial_events = [garbage, self.good_frame[:5], self.good_frame[5:]]
         for serial_event in serial_events:
             framer.processIncomingPacket(serial_event, callback)
         callback.assert_called_once()
 
-    def test_coincidental_2(self, framer, callback):
+    @pytest.mark.skip
+    def test_coincidental_2(self, framer, callback):  # pragma: no cover
         """Test conincidental."""
         garbage = b"\x02\x10\x07"
         serial_events = [garbage, self.good_frame[:5], self.good_frame[5:]]
         for serial_event in serial_events:
             framer.processIncomingPacket(serial_event, callback)
         callback.assert_called_once()
 
-    def test_coincidental_3(self, framer, callback):
+    @pytest.mark.skip
+    def test_coincidental_3(self, framer, callback):  # pragma: no cover
         """Test conincidental."""
         garbage = b"\x02\x10\x07\x10"
         serial_events = [garbage, self.good_frame[:5], self.good_frame[5:]]
@@ -139,7 +145,8 @@ def test_frame_with_trailing_data(self, framer, callback):
         # We should not respond in this case for identical reasons as test_wrapped_frame
         callback.assert_called_once()
 
-    def test_getFrameStart(self, framer):
+    @pytest.mark.skip
+    def test_getFrameStart(self, framer):  # pragma: no cover
         """Test getFrameStart."""
         result = None
         count = 0