Skip to content

Commit 12c28f5

Browse files
committed
Allow List[int] or int but not float or str
1 parent 5d7df32 commit 12c28f5

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

pymodbus/client/mixin.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def write_coil(
131131
)
132132

133133
def write_register(
134-
self, address: int, value: Union[int, float, str], slave: int = 0, **kwargs: Any
134+
self, address: int, value: int, slave: int = 0, **kwargs: Any
135135
) -> pdu_req_write.WriteSingleRegisterResponse:
136136
"""Write register (code 0x06).
137137
@@ -374,12 +374,16 @@ def diag_get_comm_event_log(
374374
return self.execute(pdu_other_msg.GetCommEventLogRequest(**kwargs))
375375

376376
def write_coils(
377-
self, address: int, values: List[bool], slave: int = 0, **kwargs: Any
377+
self,
378+
address: int,
379+
values: Union[List[bool], bool],
380+
slave: int = 0,
381+
**kwargs: Any
378382
) -> pdu_bit_write.WriteMultipleCoilsResponse:
379383
"""Write coils (code 0x0F).
380384
381385
:param address: Start address to write to
382-
:param values: List of booleans to write
386+
:param values: List of booleans to write, or a single boolean to write to all
383387
:param slave: (optional) Modbus slave ID
384388
:param kwargs: (optional) Experimental parameters.
385389
:raises ModbusException:
@@ -389,16 +393,12 @@ def write_coils(
389393
)
390394

391395
def write_registers(
392-
self,
393-
address: int,
394-
values: List[Union[int, float, str]],
395-
slave: int = 0,
396-
**kwargs: Any
396+
self, address: int, values: Union[List[int], int], slave: int = 0, **kwargs: Any
397397
) -> pdu_req_write.WriteMultipleRegistersResponse:
398398
"""Write registers (code 0x10).
399399
400400
:param address: Start address to write to
401-
:param values: List of booleans to write
401+
:param values: List of values to write, or a single value to write to all
402402
:param slave: (optional) Modbus slave unit ID
403403
:param kwargs: (optional) Experimental parameters.
404404
:raises ModbusException:
@@ -466,7 +466,7 @@ def readwrite_registers(
466466
read_address: int = 0,
467467
read_count: int = 0,
468468
write_address: int = 0,
469-
values: int = 0,
469+
values: Union[List[int], int] = [0],
470470
slave: int = 0,
471471
**kwargs
472472
) -> pdu_reg_read.ReadWriteMultipleRegistersResponse:
@@ -475,7 +475,7 @@ def readwrite_registers(
475475
:param read_address: The address to start reading from
476476
:param read_count: The number of registers to read from address
477477
:param write_address: The address to start writing to
478-
:param values: The registers to write to the specified address
478+
:param values: List of values to write, or a single value to write to all
479479
:param slave: (optional) Modbus slave unit ID
480480
:param kwargs:
481481
:raises ModbusException:

0 commit comments

Comments
 (0)