Skip to content

Fix dtype casting bug in icdf function #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 13, 2023

Closes #6648

CC @gokuld


📚 Documentation preview 📚: https://pymc--6669.org.readthedocs.build/en/6669/

@ricardoV94 ricardoV94 requested a review from twiecki April 13, 2023 08:30
@ricardoV94 ricardoV94 added this to the 5.3.0 milestone Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #6669 (b83ffca) into main (2a324bc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6669      +/-   ##
==========================================
+ Coverage   91.97%   91.98%   +0.01%     
==========================================
  Files          94       94              
  Lines       15942    15942              
==========================================
+ Hits        14662    14665       +3     
+ Misses       1280     1277       -3     
Impacted Files Coverage Δ
pymc/logprob/basic.py 99.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 23572e1 into pymc-devs:main Apr 13, 2023
@ricardoV94 ricardoV94 deleted the fix_icdf_bug branch June 5, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: basic.icdf creates tensor variable of type of the distribution, rather than probability type (float64?)
2 participants