Skip to content

some doc fixes #6200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2022
Merged

some doc fixes #6200

merged 3 commits into from
Oct 11, 2022

Conversation

OriolAbril
Copy link
Member

What is this PR about?
Trying to fix the bad and ugly version in docs and unpinning the theme (ref #6115)

Checklist

Docs / Maintenance

  • Fix bad version in the documentation navbar
  • Unpin the theme and add a lower bound to the latest release

@OriolAbril OriolAbril linked an issue Oct 10, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #6200 (fb737fa) into main (5cf7bae) will increase coverage by 0.14%.
The diff coverage is 96.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6200      +/-   ##
==========================================
+ Coverage   93.44%   93.58%   +0.14%     
==========================================
  Files         101      101              
  Lines       22093    22151      +58     
==========================================
+ Hits        20645    20731      +86     
+ Misses       1448     1420      -28     
Impacted Files Coverage Δ
pymc/tests/distributions/test_distribution.py 97.92% <ø> (ø)
pymc/tests/distributions/test_multivariate.py 99.44% <ø> (ø)
pymc/distributions/shape_utils.py 97.85% <90.90%> (-0.82%) ⬇️
pymc/distributions/timeseries.py 91.44% <95.45%> (+8.87%) ⬆️
pymc/tests/distributions/test_timeseries.py 96.95% <98.56%> (+1.49%) ⬆️
pymc/distributions/distribution.py 95.00% <100.00%> (-0.91%) ⬇️
pymc/distributions/multivariate.py 92.25% <100.00%> (+<0.01%) ⬆️
pymc/tests/distributions/test_shape_utils.py 99.76% <100.00%> (+<0.01%) ⬆️

@OriolAbril
Copy link
Member Author

I have tested the bad version issue locally and the fix does seem to work, so not a draft anymore.

@OriolAbril OriolAbril marked this pull request as ready for review October 10, 2022 22:28
@twiecki twiecki merged commit eaa51f3 into pymc-devs:main Oct 11, 2022
@twiecki
Copy link
Member

twiecki commented Oct 11, 2022

Do we need to make these changes to the pymc-examples as well?

@OriolAbril OriolAbril deleted the doc_things branch October 11, 2022 10:18
@OriolAbril
Copy link
Member Author

Yes, these and more already have an open PR: pymc-devs/pymc-examples#439

@gbrunkhorst
Copy link
Contributor

@OriolAbril is there more work to do on documentation? I am a first time contributor. I saw that there are data umbrella youtube videos that can help me to get oriented with github, but I would like some direction on what to work on. Thanks!

@OriolAbril
Copy link
Member Author

I would recommend checking #5459 or #5460 and then choose a docstring or notebook to work on in doing the changes described there.

@gbrunkhorst
Copy link
Contributor

gbrunkhorst commented Nov 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad version name showing up in the rendered docs
4 participants