-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Automatic versioning with versioneer #6078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
+ Coverage 87.29% 89.55% +2.26%
==========================================
Files 72 72
Lines 12927 12927
==========================================
+ Hits 11284 11577 +293
+ Misses 1643 1350 -293
|
@twiecki yeah, I used my work account by mistake! |
Where do these mypy errors come from? CC @michaelosthege |
Please just read the output of the mypy step. It says:
But there are a bunch of black/pylint issues in that last pre-commit run. |
@OriolAbril any idea why the RTD would be failing here? Does not seem to be related to versioning. |
I don't know, I'd have to build the docs locally to access all the logs. It might be related to the latest release of the theme. Try setting |
Yeah, the local build of docs is failing for me. Its looking for a lot of API stuff that does not exist anymore, like
|
Not sure where the other ones are coming from. In any case, they are not related to this PR, so maybe we should fix that separately and merge this in. |
These are all only warnings which have always been around since the first v4 doc build, they fill the screen with red but don't break the website generation process. We also have an issue to track this #5282 because getting rid of those is easy but the symmetric case also happens, there are still many functions that are new instead of removed and do not appear on the docs, and or that there is no warning. |
So can we merge this safely? |
The build error should have been fixed in #6120 and builds for latest are working: https://readthedocs.org/projects/pymc/builds/ so it is now safe to merge this one even if rtd didn't work. We did have more than a week where the latest tag in the docs didn't match github as the rtd build failed and it could not be updated. |
@twiecki seems like you didn't squash this? |
Yes :(. |
Oh well, time to start from scratch. PyMC5? |
Should we bring back the number as part of the package name too? 😜 |
I've added the |
Are we sure that |
Regarding my last comment, I started an experiment at #6135 |
This adds automatic versioning using the versioneer package.
Checklist
Major / Breaking Changes
Bugfixes / New features
versioneer
#4727