Skip to content

Automatic versioning with versioneer #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 14, 2022
Merged

Automatic versioning with versioneer #6078

merged 11 commits into from
Sep 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2022

This adds automatic versioning using the versioneer package.

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #6078 (37230d3) into main (c858f0f) will increase coverage by 2.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6078      +/-   ##
==========================================
+ Coverage   87.29%   89.55%   +2.26%     
==========================================
  Files          72       72              
  Lines       12927    12927              
==========================================
+ Hits        11284    11577     +293     
+ Misses       1643     1350     -293     
Impacted Files Coverage Δ
pymc/__init__.py 100.00% <100.00%> (ø)
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️
pymc/backends/arviz.py 90.61% <0.00%> (+0.81%) ⬆️
pymc/distributions/distribution.py 91.02% <0.00%> (+1.63%) ⬆️
pymc/variational/updates.py 92.11% <0.00%> (+3.44%) ⬆️
pymc/initial_point.py 99.09% <0.00%> (+5.45%) ⬆️
pymc/variational/opvi.py 87.04% <0.00%> (+11.84%) ⬆️
pymc/variational/callbacks.py 96.00% <0.00%> (+18.00%) ⬆️
pymc/variational/approximations.py 87.32% <0.00%> (+31.92%) ⬆️
pymc/variational/inference.py 86.09% <0.00%> (+34.75%) ⬆️
... and 3 more

@twiecki
Copy link
Member

twiecki commented Aug 30, 2022

image

Glad to see new and promising contributors emerge! ;)

@ghost
Copy link
Author

ghost commented Aug 30, 2022

@twiecki yeah, I used my work account by mistake!

@twiecki
Copy link
Member

twiecki commented Aug 31, 2022

Where do these mypy errors come from? CC @michaelosthege

@michaelosthege
Copy link
Member

Where do these mypy errors come from? CC @michaelosthege

Please just read the output of the mypy step. It says:

57/73 files pass as expected.
!!!!!!!!!
1 files unexpectedly passed the type checks:
pymc/_version.py
This is good news! Go to scripts/run_mypy.py and add them to the list.
!!!!!!!!!

But there are a bunch of black/pylint issues in that last pre-commit run.

@fonnesbeck fonnesbeck marked this pull request as ready for review August 31, 2022 20:10
@fonnesbeck
Copy link
Member

fonnesbeck commented Sep 1, 2022

@OriolAbril any idea why the RTD would be failing here? Does not seem to be related to versioning.

@OriolAbril
Copy link
Member

I don't know, I'd have to build the docs locally to access all the logs. It might be related to the latest release of the theme. Try setting pydata-sphinx-theme<0.10.0 in the conda envs and if it works, open an issue so we remember to look into the actual error.

@ghost
Copy link
Author

ghost commented Sep 1, 2022

Yeah, the local build of docs is failing for me. Its looking for a lot of API stuff that does not exist anymore, like pandas_to_array, AR1, etc.

WARNING: [autosummary] failed to import pymc.AR1.
Possible hints:
* AttributeError: module 'pymc' has no attribute 'AR1'
* ModuleNotFoundError: No module named 'pymc.AR1'
* ImportError: 
WARNING: [autosummary] failed to import pymc.EulerMaruyama.
Possible hints:
* ModuleNotFoundError: No module named 'pymc.EulerMaruyama'
* ImportError: 
* AttributeError: module 'pymc' has no attribute 'EulerMaruyama'
WARNING: [autosummary] failed to import pymc.KullbackLiebler.
Possible hints:
* AttributeError: module 'pymc' has no attribute 'KullbackLiebler'
* ImportError: 
* ModuleNotFoundError: No module named 'pymc.KullbackLiebler'
WARNING: [autosummary] failed to import pymc.NFVI.
Possible hints:
* ImportError: 
* ModuleNotFoundError: No module named 'pymc.NFVI'
* AttributeError: module 'pymc' has no attribute 'NFVI'
WARNING: [autosummary] failed to import pymc.NormalizingFlow.
Possible hints:
* ModuleNotFoundError: No module named 'pymc.NormalizingFlow'
* AttributeError: module 'pymc' has no attribute 'NormalizingFlow'
* ImportError: 
WARNING: [autosummary] failed to import pymc.SimulatorRV.
Possible hints:
* ImportError: 
* ModuleNotFoundError: No module named 'pymc.SimulatorRV'
* AttributeError: module 'pymc' has no attribute 'SimulatorRV'
WARNING: [autosummary] failed to import pymc.compile_pymc.
Possible hints:
* ImportError: 
* AttributeError: module 'pymc' has no attribute 'compile_pymc'
* ModuleNotFoundError: No module named 'pymc.compile_pymc'
WARNING: [autosummary] failed to import pymc.math.abs_.
Possible hints:
* AttributeError: module 'pymc.math' has no attribute 'abs_'
* ImportError: 
* ModuleNotFoundError: No module named 'pymc.math.abs_'; 'pymc.math' is not a package
WARNING: [autosummary] failed to import pymc.pandas_to_array.
Possible hints:
* AttributeError: module 'pymc' has no attribute 'pandas_to_array'
* ImportError: 
* ModuleNotFoundError: No module named 'pymc.pandas_to_array'

@twiecki
Copy link
Member

twiecki commented Sep 1, 2022

abs_ was renamed to abs, is it still mentioned in the docs?

Not sure where the other ones are coming from. In any case, they are not related to this PR, so maybe we should fix that separately and merge this in.

@OriolAbril
Copy link
Member

These are all only warnings which have always been around since the first v4 doc build, they fill the screen with red but don't break the website generation process. We also have an issue to track this #5282 because getting rid of those is easy but the symmetric case also happens, there are still many functions that are new instead of removed and do not appear on the docs, and or that there is no warning.

@twiecki
Copy link
Member

twiecki commented Sep 14, 2022

So can we merge this safely?

@OriolAbril
Copy link
Member

The build error should have been fixed in #6120 and builds for latest are working: https://readthedocs.org/projects/pymc/builds/ so it is now safe to merge this one even if rtd didn't work. We did have more than a week where the latest tag in the docs didn't match github as the rtd build failed and it could not be updated.

@twiecki twiecki merged commit c53cd2f into pymc-devs:main Sep 14, 2022
@ricardoV94
Copy link
Member

@twiecki seems like you didn't squash this?

@twiecki
Copy link
Member

twiecki commented Sep 14, 2022

Yes :(.

@ricardoV94
Copy link
Member

ricardoV94 commented Sep 14, 2022

Yes :(.

Oh well, time to start from scratch. PyMC5?

@OriolAbril
Copy link
Member

Should we bring back the number as part of the package name too? 😜

@michaelosthege michaelosthege added the major Include in major changes release notes section label Sep 15, 2022
@michaelosthege
Copy link
Member

I've added the major label, because this changes how the pm.__version__ looks like.
Whoever makes the release please explain/link how to deal with version number comparisons for installs from GitHub =)

@maresb
Copy link
Contributor

maresb commented Sep 17, 2022

Are we sure that versioneer needs to be added to the install requirements? This doesn't look right to me.

@maresb
Copy link
Contributor

maresb commented Sep 17, 2022

Regarding my last comment, I started an experiment at #6135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use something like versioneer
7 participants