Create dispatch functions for resize_dist and ndim_supp_dist #5702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Apr 8, 2022
Comment on lines
+567
to
+568
| # Create a temporary dist to obtain the ndim_supp | ||
| ndim_supp = ndim_supp_dist(cls.rv_op(*dist_params, size=size)) |
There was a problem hiding this comment.
This is not great, but can't think of a less wasteful way
ricardoV94
force-pushed
the
dispatch_resizing_ndim_supp
branch
from
daa6163 to
4702bd4
Compare
Codecov Report
@@ Coverage Diff @@
## main #5702 +/- ##
==========================================
- Coverage 88.89% 84.74% -4.15%
==========================================
Files 75 75
Lines 13746 13770 +24
==========================================
- Hits 12219 11669 -550
- Misses 1527 2101 +574
|
ricardoV94
changed the title
|
Closed in favor of #6072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to better manipulate SymbolicDistributions and get closer to #5533