-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update Aesara version and unpin numpy #5369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any idea what's wrong with the conda setup? |
I think I was just too fast before conda-forge had aesara packages up. |
Codecov Report
@@ Coverage Diff @@
## main #5369 +/- ##
==========================================
+ Coverage 80.36% 82.71% +2.34%
==========================================
Files 89 132 +43
Lines 14808 26042 +11234
==========================================
+ Hits 11901 21541 +9640
- Misses 2907 4501 +1594
|
|
Not sure why this stalls out, it passes locally. Any idea @ricardoV94 @michaelosthege ? |
Are you testing with the latest Aesara? It fails locally for me. I think I know where the problem is... |
Alright, I wasn't. What's the problem? |
Still trying to pin it down. Those ODE Ops are super hackish xD |
I think there is a broken cyclical optimization on the Aesara side |
Yup, found it. |
1e22653
to
a05395b
Compare
* Remove deprecated kwarg in `broadcast_to` * Update type equality check in `DifferentialEquation` `Op`
This reverts commit b29124b.
a05395b
to
dfca222
Compare
When chains have different lengths, this test would fail because the resulting `log_marginal_likelihood` would be non-square
Closes #5321.
Reverts temporary #5332.