add moment for BART distribution #5211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5211 +/- ##
==========================================
- Coverage 78.12% 77.98% -0.14%
==========================================
Files 88 88
Lines 14174 14227 +53
==========================================
+ Hits 11073 11095 +22
- Misses 3101 3132 +31
|
ricardoV94
reviewed
Nov 19, 2021
| @@ -132,6 +137,13 @@ def logp(x, *inputs): | |||
| """ | |||
| return at.zeros_like(x) | |||
|
|
|||
| @classmethod | |||
| def get_moment(cls, rv, size, *rv_inputs): | |||
There was a problem hiding this comment.
Could BART shape be determined by the shape of the rv_inputs? Or does the mean already integrate this info?
There was a problem hiding this comment.
The shape of BART is always the shape of observed data Y.
There was a problem hiding this comment.
And do you do anything with the size variable or is that branch below unnecessary?
There was a problem hiding this comment.
everything is a lie :-) Initially I tough about having a size argument for future extension. But probably that will not be very useful.
pymc/bart/bart.py
Outdated
| @classmethod | ||
| def get_moment(cls, rv, size, *rv_inputs): | ||
| mean = rv.Y.mean() | ||
| if not rv_size_is_none(size): |
There was a problem hiding this comment.
Can you add a condition that hits this branch?
51 tasks
ricardoV94
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #5078