Skip to content

Added moments for gumbel, triangular and logitnormal distributions for issue #5078 #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

sagartomar
Copy link
Contributor

@sagartomar sagartomar commented Nov 12, 2021

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #5180 (7816c73) into main (8d1708a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5180   +/-   ##
=======================================
  Coverage   78.05%   78.06%           
=======================================
  Files          88       88           
  Lines       14146    14161   +15     
=======================================
+ Hits        11042    11055   +13     
- Misses       3104     3106    +2     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 96.44% <100.00%> (+0.06%) ⬆️
pymc/data.py 79.55% <0.00%> (-0.45%) ⬇️
pymc/sampling.py 86.68% <0.00%> (-0.13%) ⬇️

@ricardoV94 ricardoV94 mentioned this pull request Nov 12, 2021
51 tasks
@ricardoV94
Copy link
Member

Looks great! Just need to fix the pre-commit formatting complaints

@ricardoV94 ricardoV94 merged commit 073e26b into pymc-devs:main Nov 13, 2021
@ricardoV94
Copy link
Member

Failing test seems related to know issues about MAP and not this PR. Merged it!

@sagartomar sagartomar deleted the moments branch November 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants