Skip to content

Add Pareto and Wald moment #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

azihna
Copy link
Contributor

@azihna azihna commented Nov 9, 2021

Add moments and tests for the below distribution as part of #5078

  • pymc.distributions.continuous.Pareto
  • pymc.distributions.continuous.Wald

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening that PR. I left some comments below

@ricardoV94 ricardoV94 mentioned this pull request Nov 9, 2021
51 tasks
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azihna I just rebased on main and removed some other obsolete code. Should be good to merge if tests pass

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #5161 (7c4d5ab) into main (31b4a37) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5161      +/-   ##
==========================================
+ Coverage   78.04%   78.08%   +0.03%     
==========================================
  Files          88       88              
  Lines       14135    14143       +8     
==========================================
+ Hits        11032    11043      +11     
+ Misses       3103     3100       -3     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 96.36% <100.00%> (+0.37%) ⬆️

@ricardoV94 ricardoV94 merged commit 5dacdae into pymc-devs:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants