-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Logistic Moment #5157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logistic Moment #5157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion to make the test more robust.
Also thanks for opening a PR!
Co-authored-by: Ricardo Vieira <[email protected]>
@shivam15s There are some conflicts that have to be resolved due to other PRs having been merged in the meantime |
Codecov Report
@@ Coverage Diff @@
## main #5157 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 88 88
Lines 14118 14123 +5
=======================================
+ Hits 11015 11020 +5
Misses 3103 3103
|
@ricardoV94 Don't know why |
Seems related to aesara-devs/aeppl#84 Should not be affected by this PR |
Unfortunately you will have to resolve conflicts once again. There were more PRs that were just merged. |
Just merged. Thanks a lot @shivam15s and looking forward to your next PR |
Add moment and tests for the below distribution as part of #5078