Skip to content

Add Logistic Moment #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Add Logistic Moment #5157

merged 8 commits into from
Nov 8, 2021

Conversation

shivam15s
Copy link
Contributor

Add moment and tests for the below distribution as part of #5078

  • pymc.distributions.continuous.Logistic

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to make the test more robust.

Also thanks for opening a PR!

@ricardoV94 ricardoV94 mentioned this pull request Nov 8, 2021
51 tasks
@shivam15s shivam15s requested a review from ricardoV94 November 8, 2021 16:28
@ricardoV94
Copy link
Member

@shivam15s There are some conflicts that have to be resolved due to other PRs having been merged in the meantime

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #5157 (ec7a59c) into main (93c2293) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5157   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files          88       88           
  Lines       14118    14123    +5     
=======================================
+ Hits        11015    11020    +5     
  Misses       3103     3103           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 95.99% <100.00%> (+0.02%) ⬆️

@shivam15s
Copy link
Contributor Author

shivam15s commented Nov 8, 2021

@ricardoV94 Don't know why test_bart.py failed. It seems to work locally.
image

@ricardoV94
Copy link
Member

Seems related to aesara-devs/aeppl#84

Should not be affected by this PR

@ricardoV94
Copy link
Member

Unfortunately you will have to resolve conflicts once again. There were more PRs that were just merged.

@ricardoV94 ricardoV94 merged commit bdd4d19 into pymc-devs:main Nov 8, 2021
@ricardoV94
Copy link
Member

Just merged. Thanks a lot @shivam15s and looking forward to your next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants