Skip to content

Add Constant Moment #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 8, 2021
Merged

Add Constant Moment #5156

merged 6 commits into from
Nov 8, 2021

Conversation

Harshp1802
Copy link
Contributor

No description provided.

@Harshp1802 Harshp1802 requested a review from ricardoV94 November 8, 2021 15:34
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above... no reason to test more than needed :)

@ricardoV94 ricardoV94 mentioned this pull request Nov 8, 2021
51 tasks
@Harshp1802 Harshp1802 requested a review from ricardoV94 November 8, 2021 16:34
@ricardoV94
Copy link
Member

You will have to resolve the conflicts because of other PRs that were already merged

@Harshp1802
Copy link
Contributor Author

You will have to resolve the conflicts because of other PRs that were already merged

Done ✌🏻

@ricardoV94
Copy link
Member

Seems like you have some linting issues, you may check this guide: https://github.com/pymc-devs/pymc/wiki/Python-Code-Style

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #5156 (4fe636a) into main (45d48a6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5156      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.01%     
==========================================
  Files          88       88              
  Lines       14109    14113       +4     
==========================================
+ Hits        11007    11009       +2     
- Misses       3102     3104       +2     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 99.37% <100.00%> (+0.32%) ⬆️
pymc/backends/report.py 89.51% <0.00%> (-2.10%) ⬇️

@ricardoV94 ricardoV94 merged commit 93c2293 into pymc-devs:main Nov 8, 2021
@ricardoV94
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants