Add HalfStudentT moment #5152
Merged
Add HalfStudentT moment #5152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
requested changes
Nov 8, 2021
ricardoV94
reviewed
Nov 8, 2021
51 tasks
ricardoV94
requested changes
Nov 8, 2021
Co-authored-by: Ricardo Vieira <[email protected]>
ricardoV94
approved these changes
Nov 8, 2021
|
Pre-commit was failing due to sorting of imports. There is a guide here on how to setup locally to make sure it's working before pushing: https://github.com/pymc-devs/pymc/wiki/Python-Code-Style |
Codecov Report
@@ Coverage Diff @@
## main #5152 +/- ##
==========================================
+ Coverage 77.86% 78.00% +0.14%
==========================================
Files 88 88
Lines 14165 14114 -51
==========================================
- Hits 11029 11010 -19
+ Misses 3136 3104 -32
|
ricardoV94
requested changes
Nov 8, 2021
| (1, 1, 5, np.ones(5)), | ||
| (1, np.arange(5), None, np.arange(5)), | ||
| (1, np.arange(5), (2, 5), np.full((2, 5), np.arange(5))), | ||
| (np.arange(1, 6), 1, 5, np.full(5, 1)), |
There was a problem hiding this comment.
This one does not really test the broadcast because size is not None. Maybe something like this?
Suggested change
| (np.arange(1, 6), 1, 5, np.full(5, 1)), | |
| (np.arange(1, 6), 1, None, np.full(5, 1)), |
And you can remove one of the previous 2 tests, we don't need 5 in total.
There was a problem hiding this comment.
Sure! Thanks for your patience!
ricardoV94
approved these changes
Nov 8, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add moments and tests for the below distribution as part of #5078
pymc.distributions.continuous.HalfStudentT