Skip to content

Add Beta moment and tests for #5078 #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2021

Conversation

michaeloriordan
Copy link
Contributor

Add Beta moment and tests for #5078

Co-authored-by: Ricardo Vieira <[email protected]>
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #5145 (d227d76) into main (5f9a2e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5145   +/-   ##
=======================================
  Coverage   77.78%   77.79%           
=======================================
  Files          88       88           
  Lines       14115    14120    +5     
=======================================
+ Hits        10979    10984    +5     
  Misses       3136     3136           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 95.57% <100.00%> (+0.02%) ⬆️

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @michaeloriordan!

Although it seems the pre-commit is complaining about the end of file: https://github.com/pymc-devs/pymc/wiki/Python-Code-Style

@michaeloriordan
Copy link
Contributor Author

Missed the pre-commit step, should be fixed now. Thanks @ricardoV94!

@ricardoV94 ricardoV94 merged commit 444d66a into pymc-devs:main Nov 6, 2021
@ricardoV94
Copy link
Member

Merged @michaeloriordan. Looking forward to your next PR!

@twiecki
Copy link
Member

twiecki commented Nov 6, 2021

Thanks @michaeloriordan, and congrats on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants