Add Beta moment and tests for #5078 #5145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
ricardoV94
reviewed
Nov 5, 2021
Co-authored-by: Ricardo Vieira <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5145 +/- ##
=======================================
Coverage 77.78% 77.79%
=======================================
Files 88 88
Lines 14115 14120 +5
=======================================
+ Hits 10979 10984 +5
Misses 3136 3136
|
ricardoV94
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Looks good. Thanks @michaeloriordan!
Although it seems the pre-commit is complaining about the end of file: https://github.com/pymc-devs/pymc/wiki/Python-Code-Style
|
Missed the pre-commit step, should be fixed now. Thanks @ricardoV94! |
ricardoV94
approved these changes
Nov 6, 2021
|
Merged @michaeloriordan. Looking forward to your next PR! |
|
Thanks @michaeloriordan, and congrats on your first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Beta moment and tests for #5078