-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixed Interpolated Distribution's interval transform initialization #5067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5067 +/- ##
==========================================
- Coverage 78.94% 78.00% -0.94%
==========================================
Files 88 88
Lines 14248 14132 -116
==========================================
- Hits 11248 11024 -224
- Misses 3000 3108 +108
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should add a regression test
47f4897
to
7bbbec4
Compare
7bbbec4
to
60d115e
Compare
@kc611 I updated the PR. Let me know if you see any problems |
60d115e
to
99d8c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Back then I was confused as of what tests to add. This looks pretty reasonable.
This also fixes a previous failure on float32
99d8c41
to
b040aa4
Compare
Linked Issue: #5048