Skip to content

Fixed Interpolated Distribution's interval transform initialization #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Oct 10, 2021

Linked Issue: #5048

@kc611 kc611 marked this pull request as draft October 10, 2021 04:41
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #5067 (7bbbec4) into main (99ec0ff) will decrease coverage by 0.93%.
The diff coverage is 42.85%.

❗ Current head 7bbbec4 differs from pull request most recent head b040aa4. Consider uploading reports for the commit b040aa4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5067      +/-   ##
==========================================
- Coverage   78.94%   78.00%   -0.94%     
==========================================
  Files          88       88              
  Lines       14248    14132     -116     
==========================================
- Hits        11248    11024     -224     
- Misses       3000     3108     +108     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 95.12% <42.85%> (-1.46%) ⬇️
pymc/gp/gp.py 60.25% <0.00%> (-33.36%) ⬇️
pymc/gp/util.py 80.00% <0.00%> (-14.69%) ⬇️
pymc/distributions/simulator.py 86.25% <0.00%> (-0.51%) ⬇️
pymc/math.py 68.18% <0.00%> (-0.51%) ⬇️
pymc/bart/bart.py 95.45% <0.00%> (-0.47%) ⬇️
pymc/distributions/distribution.py 94.53% <0.00%> (-0.18%) ⬇️
pymc/distributions/logprob.py 94.93% <0.00%> (-0.11%) ⬇️
pymc/distributions/multivariate.py 71.27% <0.00%> (-0.07%) ⬇️
... and 14 more

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should add a regression test

@kc611 kc611 force-pushed the interpolated_issue branch from 47f4897 to 7bbbec4 Compare November 9, 2021 09:38
@ricardoV94 ricardoV94 marked this pull request as ready for review November 25, 2021 13:03
@ricardoV94
Copy link
Member

@kc611 I updated the PR. Let me know if you see any problems

Copy link
Contributor Author

@kc611 kc611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Back then I was confused as of what tests to add. This looks pretty reasonable.

This also fixes a previous failure on float32
@ricardoV94 ricardoV94 merged commit 5107dae into pymc-devs:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants