-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove workaround in InferenceData conversion; require ArviZ >=0.11.4 #5060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -160,7 +120,6 @@ def __init__( | |||
model=None, | |||
save_warmup: Optional[bool] = None, | |||
density_dist_obs: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't need to be in this PR, but we can remove this argument. densitydist api will be fixed in v4 so this is no longer necessary.
Codecov Report
@@ Coverage Diff @@
## main #5060 +/- ##
==========================================
- Coverage 78.42% 78.41% -0.01%
==========================================
Files 130 130
Lines 24475 24461 -14
==========================================
- Hits 19195 19182 -13
+ Misses 5280 5279 -1
|
7976dcb
to
70ebe4c
Compare
thanks for dealing with the dependencies, @OriolAbril ! I just rebased on main to resolve conflicts. Also I rearranged the commits such that the dependency upgrade is now all in one. Let's hope the CI likes it. |
70ebe4c
to
30887e5
Compare
@OriolAbril can you check the diff again? I had to mark a test as XFAIL because I couldn't reproduce the float64/float32 casting error locally. |
The changes from 33dd132 (probably unpinning NumPy) fixed `test_wald_logcdf` and broke `test_negative_binomial`.
30887e5
to
b18a09e
Compare
Can merge once we get green light. |
👍 |
This PR removes a workaround in the InferenceData conversion and at the same time fixes a bug that was present in the workaround.
Depending on what your PR does, here are a few things you might want to address in the description: