Allow passing name as kwarg to pm.Bound RVs
#3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpenglao
reviewed
Aug 12, 2018
pymc3/tests/test_distributions.py
Outdated
| @@ -1183,6 +1183,10 @@ def test_bound(): | |||
| assert rand.dtype in [np.int16, np.int32, np.int64] | |||
| assert rand >= 5 and rand <= 8 | |||
|
|
|||
| with pm.Model(): | |||
| BoundPoisson = pm.Bound(pm.Poisson, upper=6) | |||
| BoundPoisson(name="y", mu=1) | |||
There was a problem hiding this comment.
Hmmmmmmmmm we never do this... it is always BoundPoisson("y", mu=1)
There was a problem hiding this comment.
(You must have been playing around with TFP and Edwards2 lately LOL)
There was a problem hiding this comment.
Wasn't me :-)
I think an explicit name should work though. That is just the norm in python.
There was a problem hiding this comment.
I see. We do have the same pattern in FreeRV etc
There was a problem hiding this comment.
This works:
with pm.Model() as model:
pm.Normal(name='a')
pm.Normal(name='b', observed=[0.])
This fails without this patch:
BoundPoisson = pm.Bound(pm.Poisson, upper = 6)
y = BoundPoisson(name="y", mu=1)
aseyboldt
force-pushed
the
kwargs-bounds
branch
from
ff4abb7 to
aee27e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3149.