Skip to content

Enforce MvStudentT nu to be a scalar variable #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Nov 20, 2021 · 2 comments
Closed

Enforce MvStudentT nu to be a scalar variable #5214

ricardoV94 opened this issue Nov 20, 2021 · 2 comments

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 20, 2021

#5173 revealed a bit of an edge case in the MvStudentT with broadcasting when nu is a vector. Since we haven't tested whether the RV, logp, and logcdf, are doing the right thing in that case, we should assert that nu is a scalar in the make_node method of the respective RandomVariable.

We can always remove this restriction if we confirm things are working consistently with the rules of broadcasting.

@sagartomar
Copy link
Contributor

I would like to work on this. It looks like we need to override the make_node method in MvStudentTRV class and need to check if nu is scalar and if the check passes then call the super class' make_node method.

@twiecki
Copy link
Member

twiecki commented Nov 29, 2021

Great, go for it @sagartomar 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants