Skip to content

TestNutsCheckTrace.test_linalg is flaky #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelosthege opened this issue Oct 9, 2021 · 1 comment
Closed

TestNutsCheckTrace.test_linalg is flaky #5063

michaelosthege opened this issue Oct 9, 2021 · 1 comment
Labels
maintenance needs info Additional information required tests

Comments

@michaelosthege
Copy link
Member

This test is failing on main, but only sometimes: https://github.com/pymc-devs/pymc/runs/3841109220#step:7:1987

[XPASS(strict)] Start shape checks that were previously skipped run into ValueError

What can we do to make the test deterministic?

  • PyMC/PyMC3 Version: main
@michaelosthege michaelosthege added tests maintenance needs info Additional information required labels Oct 9, 2021
@michaelosthege michaelosthege mentioned this issue Oct 9, 2021
Merged
michaelosthege added a commit to michaelosthege/pymc that referenced this issue Oct 9, 2021
@michaelosthege
Fix flaky test pymc-devs#5063
db07070 
The at.slinalg.solve applies the finite-checks also in shape-inference.
Since 00e6eb9 we do shape checks every
time, making this test error out with a 75 % probability.
twiecki pushed a commit that referenced this issue Oct 9, 2021
@michaelosthege @twiecki
Fix flaky test #5063
d8bb334 
The at.slinalg.solve applies the finite-checks also in shape-inference.
Since 00e6eb9 we do shape checks every
time, making this test error out with a 75 % probability.
@michaelosthege
Copy link
Member Author

Closed by d8bb334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance needs info Additional information required tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelosthege