Skip to content

Have pooling model images be local as they keep disappearing. #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Feb 13, 2022

Fixes #216.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super in favour of adding the images locally, but they should still use the markdown image syntax (which works for both remote and local images) as the html version is parsed as raw content by sphinx, so the images are not copied correctly when generating the html pages, you can see that the preview still has broken images: https://pymc--282.org.readthedocs.build/projects/examples/en/282/case_studies/multilevel_modeling.html#multilevel-and-hierarchical-models

@canyon289
Copy link
Member

@twiecki FYI theres some bug on github viewer for NB images. @AlexAndorra was running into the same thing

@ghost
Copy link

ghost commented Feb 26, 2022

Working on this now. Will push a fix today.

@twiecki
Copy link
Member Author

twiecki commented Apr 1, 2022

@fonnesbeck is this superseded by #285?

@twiecki twiecki closed this Apr 1, 2022
@twiecki twiecki deleted the fix_pool_images branch May 22, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchical NB has missing images
3 participants