Don't emit `super-init-not-called` for abstract `init` methods #7227

DanielNoord · 2022-07-25T14:46:27Z

Add yourself to CONTRIBUTORS if you are a new contributor.
Add a ChangeLog entry describing what your PR does.
If it's a new feature, or an important bug fix, add a What's New entry in
doc/whatsnew/<current release.rst>.
Write a good description on what the PR does.

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #3975.

coveralls · 2022-07-25T15:00:30Z

Pull Request Test Coverage Report for Build 2770142168

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 95.244%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/classes/class_checker.py	2	94.61%

Totals
Change from base Build 2770034625:	-0.01%
Covered Lines:	16822
Relevant Lines:	17662

💛 - Coveralls

Pierre-Sassoulas · 2022-07-25T15:20:55Z

I have no idea why the coverage went down on the three lines that are not covered anymore. coverall issue ?

vivi90 · 2022-07-25T18:15:16Z

#3975 (comment)

DanielNoord · 2022-07-25T21:54:22Z

I think this is because "living" objects don't have a body and thus are considered abstract.
This prevents them from raising inference errors later on.

See also change to the ctypes test

DanielNoord · 2022-07-27T07:09:00Z

@Pierre-Sassoulas can this be merged with the decreased coverage?

Pierre-Sassoulas · 2022-07-27T07:45:35Z

Maybe it's possible to cleanup or to add a test that cover this ? If it's too complicated I'm ok with merging as is, the primer indicate the change will remove a lot of false positives.

vivi90 · 2022-07-27T14:07:00Z

I think, it might be an very bad idea to change pylints current behaviour for this case, because of: #3975 (comment)

Pierre-Sassoulas · 2022-07-30T18:28:35Z

Look like the fail is genuine and was hidden by the broken main before.

DanielNoord · 2022-07-31T16:25:56Z

pylint/checkers/classes/class_checker.py

@@ -2061,9 +2061,6 @@ def _check_init(self, node: nodes.FunctionDef, klass_node: nodes.ClassDef) -> No

            if decorated_with(node, ["typing.overload"]):
                continue


The lines below are no longer necessary now that we skip object.__init__ because of its abstractness.

DanielNoord · 2022-07-31T16:26:43Z

tests/functional/s/super/super_init_not_called.py

+        return "Implemented"
+
+
+class DerivedFrom(UnknownParent):  # [undefined-variable]


This is a regression test for the coverage that dropped. We try to infer bases which fails here.

github-actions · 2022-07-31T16:59:32Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'UploadFileException' is not called
https://github.com/django/django/blob/main/django/core/files/uploadhandler.py#L36
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/django/django/blob/main/django/core/serializers/base.py#L66
super-init-not-called:
init method from base class 'TextIOBase' is not called
https://github.com/django/django/blob/main/django/core/management/base.py#L150
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/django/django/blob/main/django/middleware/csrf.py#L132
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/django/django/blob/main/django/middleware/csrf.py#L167
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/django/django/blob/main/django/template/base.py#L102
super-init-not-called:
init method from base class 'LookupError' is not called
https://github.com/django/django/blob/main/django/db/migrations/exceptions.py#L43
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/django/django/blob/main/django/db/models/sql/datastructures.py#L15
super-init-not-called:
init method from base class 'str' is not called
https://github.com/django/django/blob/main/django/conf/__init__.py#L52

Effect on flask:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'KeyError' is not called
https://github.com/pallets/flask/blob/main/src/flask/debughelpers.py#L19
super-init-not-called:
init method from base class 'AssertionError' is not called
https://github.com/pallets/flask/blob/main/src/flask/debughelpers.py#L19

Effect on pandas:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'BaseBlockManager' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/managers.py#L888
super-init-not-called:
init method from base class 'BaseBlockManager' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/managers.py#L1694
super-init-not-called:
init method from base class 'BaseArrayManager' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/array_manager.py#L712
super-init-not-called:
init method from base class 'BaseArrayManager' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/array_manager.py#L1201
super-init-not-called:
init method from base class 'set' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_set_index.py#L676
super-init-not-called:
init method from base class 'NotImplementedError' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/errors/__init__.py#L188
super-init-not-called:
init method from base class 'dict' is not called
https://github.com/pandas-dev/pandas/blob/main/pandas/plotting/_misc.py#L558

Effect on psycopg:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/psycopg/psycopg/blob/master/psycopg/psycopg/transaction.py#L40

Effect on pytest:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'LookupError' is not called
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L792
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/mark/expression.py#L61
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/config/argparsing.py#L207

Effect on sentry:
The following messages are no longer emitted:

super-init-not-called:
init method from base class 'InvalidRequest' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/exceptions.py#L17
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/coreapi.py#L24
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/incidents/logic.py#L850
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/api/client.py#L11
super-init-not-called:
init method from base class 'NodeStorage' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/nodestore/bigtable/backend.py#L33
super-init-not-called:
init method from base class '_local' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/metrics/base.py#L10
super-init-not-called:
init method from base class '_local' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/cache/base.py#L22
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/tasks/symbolication.py#L43
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/sms.py#L13
super-init-not-called:
init method from base class 'Exception' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/auth.py#L79
super-init-not-called:
init method from base class '_local' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/services.py#L251
super-init-not-called:
init method from base class '_local' is not called
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/performance/sqlquerycount.py#L12

This comment was generated for commit 03dd537

DanielNoord added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jul 25, 2022

DanielNoord added this to the 2.15.0 milestone Jul 25, 2022

Pierre-Sassoulas approved these changes Jul 25, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

This was referenced Jul 27, 2022

False positive __init__ method from base class is not called when the constructor raises NotImplementedError without using abc #3975

Closed

Use 3.11 for Github actions #6551

Merged

This comment has been minimized.

Sign in to view

Don't emit super-init-not-called for abstract __init__ methods

03dd537

DanielNoord force-pushed the init branch from 0333b72 to 03dd537 Compare July 31, 2022 16:25

DanielNoord commented Jul 31, 2022

View reviewed changes

Pierre-Sassoulas merged commit 397c170 into pylint-dev:main Jul 31, 2022

AdamWill mentioned this pull request Jul 31, 2022

Don't emit super-init-not-called for Enum subclasses #7181

Closed

DanielNoord deleted the init branch July 31, 2022 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't emit `super-init-not-called` for abstract `init` methods #7227

Don't emit `super-init-not-called` for abstract `init` methods #7227

DanielNoord commented Jul 25, 2022

coveralls commented Jul 25, 2022 •

edited

Loading

Pierre-Sassoulas commented Jul 25, 2022

This comment has been minimized.

vivi90 commented Jul 25, 2022

DanielNoord commented Jul 25, 2022

DanielNoord commented Jul 27, 2022

Pierre-Sassoulas commented Jul 27, 2022

vivi90 commented Jul 27, 2022 •

edited

Loading

Pierre-Sassoulas commented Jul 30, 2022

This comment has been minimized.

DanielNoord Jul 31, 2022

DanielNoord Jul 31, 2022

github-actions bot commented Jul 31, 2022

		@@ -2061,9 +2061,6 @@ def _check_init(self, node: nodes.FunctionDef, klass_node: nodes.ClassDef) -> No

		if decorated_with(node, ["typing.overload"]):
		continue

		return "Implemented"


		class DerivedFrom(UnknownParent): # [undefined-variable]

Don't emit super-init-not-called for abstract __init__ methods #7227

Don't emit super-init-not-called for abstract __init__ methods #7227

Conversation

DanielNoord commented Jul 25, 2022

Type of Changes

Description

coveralls commented Jul 25, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2770142168

💛 - Coveralls

Pierre-Sassoulas commented Jul 25, 2022

This comment has been minimized.

vivi90 commented Jul 25, 2022

DanielNoord commented Jul 25, 2022

DanielNoord commented Jul 27, 2022

Pierre-Sassoulas commented Jul 27, 2022

vivi90 commented Jul 27, 2022 • edited Loading

Pierre-Sassoulas commented Jul 30, 2022

This comment has been minimized.

DanielNoord Jul 31, 2022

Choose a reason for hiding this comment

DanielNoord Jul 31, 2022

Choose a reason for hiding this comment

github-actions bot commented Jul 31, 2022

Don't emit `super-init-not-called` for abstract `init` methods #7227

Don't emit `super-init-not-called` for abstract `init` methods #7227

coveralls commented Jul 25, 2022 •

edited

Loading

vivi90 commented Jul 27, 2022 •

edited

Loading