-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Increase new primer timeout to 60m #7156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase new primer timeout to 60m #7156
Conversation
We can't count on the github runner machine to have more than one core consistently, so we probably need both parallelization |
Oooh, that's a much larger ask then. I looked at that briefly a month ago and then realized there's no good solution for streaming JSON results to a file. |
Pull Request Test Coverage Report for Build 2645542754
💛 - Coveralls |
I do think the "partial" cores the runner machines offer could be used if we created a more barebones way of parallelisation. Instead of creating a completely new I really don't have time to look into this in the coming weeks due to deadlines and holidays, but I would certainly be interested in a (Discord/Zoom) call in August or September to discuss some possibilities. It seems this requires such large refactoring efforts that it would be good to both discuss the approach and perhaps even divide some tasks. |
My time is also limited these next few months but in general 👍🏻 |
@jacobtylerwalls https://github.com/PyCQA/pylint/runs/7271165374?check_suite_focus=true Am I overseeing something or is Edit: Ah, this is funny. Because we haven't upped the constraint in Anybody got a good solution? |
Should we relax the requirement even more ? I don't think a lot could go wrong (as long as we set it correctly before release). We can use tbump for that. |
See last run on main. The 3.7 job sometimes takes just barely over 45 minutes. The old primer timeout was set to 60m.
Clearly we need to add some concurrency. Rather than parallelizing the primer message comparison infrastructure, my hope is that we can just (later this year or next) solve the underlying issues with
--jobs
(see labeltopic: multiprocessing
) and use that.